Use default JavaExec error message when main class is not set#1725
Merged
Use default JavaExec error message when main class is not set#1725
JavaExec error message when main class is not set#1725Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reverts a previous change that added a custom error message when the main class is not set in the Shadow Application Plugin, instead allowing the default JavaExec error message to be used.
- Removes custom error handling for missing main class in shadow jar configuration
- Updates tests to expect the default JavaExec error message format
- Documents the change in the changelog
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ShadowApplicationPlugin.kt | Removes custom main class validation and error message, simplifies manifest attribute injection logic |
| ApplicationPluginTest.kt | Updates test to expect default JavaExec error message instead of custom shadow error |
| README.md | Documents the change in the unreleased changelog section |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowApplicationPlugin.kt
Outdated
Show resolved
Hide resolved
…dowApplicationPlugin.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Goooler
changed the title
JavaExec error message when main class is not set
Goooler
force-pushed
the
g/20250908/revert-1601
branch
from
3f17503 to
787b5c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainClassName#1601Main-Classmanifest attr logic fromdoFirstintocopy#1724